Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve absolute path to file url correctly #206

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix: resolve absolute path to file url correctly #206

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5752906
fix: resolve path to file url correctly
novarolV Jan 16, 2024
e288fb3
check if path absolute
novarolV Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/worker.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { runAsWorker } from 'synckit';
import { pathToFileURL } from 'url';

runAsWorker(
/**
Expand All @@ -15,7 +16,7 @@ runAsWorker(
text, prettierEslintPath, filePath, extensionConfig,
}) => {
const format = /** @type {typeof import('prettier-eslint')} */ (
(await import(prettierEslintPath)).default
(await import(pathToFileURL(prettierEslintPath))).default
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(await import(pathToFileURL(prettierEslintPath))).default
(await import(isAbsolutePath(prettierEslintPath) ？ pathToFileURL(prettierEslintPath) : prettierEslintPath)).default

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, see my new commit.

);
return format({
text,
Expand Down