chore: update eslint, prettier, eslint-prettier to current #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaked snapshots and eslint configurations slightly to accommodate them. Docs: Add @cwilbur as a contributor
idahogurl
requested changes
Oct 27, 2023
| first: "hello, world", | ||
| first: 'hello, world', |
There was a problem hiding this comment.
This indicates that there is a bug as the snapshots shouldn't change between versions
| first: "hello, world", | ||
| first: 'hello, world', |
There was a problem hiding this comment.
This indicates that there is a bug as the snapshots shouldn't change between versions
| @@ -0,0 +1 @@ | |||
| layout node | |||
Closed
idahogurl
reviewed
Oct 27, 2023
| "node": "^16.13.0" | ||
| "node": "^21.0.0" |
There was a problem hiding this comment.
I'd rather not update this as it's not needed by the code or any of the packages.
idahogurl
reviewed
Oct 27, 2023
| "@auto-it/upload-assets": "^11.0.4", | ||
| "@types/node": "^20.8.6", | ||
| "@vscode/test-electron": "^2.3.5", | ||
| "@vscode/vsce": "^2.21.1", |
idahogurl
reviewed
Oct 27, 2023
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5", | ||
| "typescript": "^5.2.2", | ||
| "@eslint/eslintrc": "^2.1.2", |
idahogurl
reviewed
Oct 27, 2023
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5", | ||
| "typescript": "^5.2.2", |
There was a problem hiding this comment.
If you update TypeScript then you have to update the examples. Rather we do the least amount of changes
|
@idahogurl Here is a PR with the minimum changes: #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked snapshots and eslint configurations slightly to accommodate them.
Docs: Add @cwilbur as a contributor