Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint, prettier, eslint-prettier to current #189

Closed
wants to merge 1 commit into from
Closed

chore: update eslint, prettier, eslint-prettier to current #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@
"contributions": [
"doc"
]
},
{
"login": "cwilbur",
"name": "Charlton Wilbur",
"avatar_url": "https://avatars.githubusercontent.com/u/2566621?v=4",
"profile": "https://github.com/cwilbur",
"contributions": [
"maintenance"
]
}
],
"contributorsPerLine": 7
Expand Down
1 change: 1 addition & 0 deletions .envrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
layout node
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this file? 🙂

3 changes: 2 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
dist/
examples/
test/fixtures/
test/fixtures/node_modules/
eslint.config.js
17 changes: 9 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<img src="https://github.com/idahogurl/vs-code-prettier-eslint/blob/master/icon.png?raw=true" width="150">

<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->

[![All Contributors](https://img.shields.io/badge/all_contributors-3-orange.svg?style=flat-square)](#contributors-)

[![All Contributors](https://img.shields.io/badge/all_contributors-4-orange.svg?style=flat-square)](#contributors-)
<!-- ALL-CONTRIBUTORS-BADGE:END -->

# [VS Code Prettier ESLint](https://marketplace.visualstudio.com/items?itemName=rvest.vs-code-prettier-eslint)
Expand Down Expand Up @@ -162,11 +160,14 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<!-- prettier-ignore-start -->
<!-- markdownlint-disable -->
<table>
<tr>
<td align="center"><a href="https://github.com/idahogurl"><img src="https://secure.gravatar.com/avatar/787139c4c697cfc33cc422566a4ccf78?s=80&d=identicon?s=100" width="100px;" alt=""/><br /><sub><b>Rebecca Vest</b></sub></a><br /><a href="#question-idahogurl" title="Answering Questions">💬</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=idahogurl" title="Code">💻</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=idahogurl" title="Documentation">📖</a> <a href="#infra-idahogurl" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/issues?q=author%3Aidahogurl" title="Bug reports">🐛</a> <a href="#ideas-idahogurl" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/pulls?q=is%3Apr+reviewed-by%3Aidahogurl" title="Reviewed Pull Requests">👀</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=idahogurl" title="Tests">⚠️</a></td>
<td align="center"><a href="https://github.com/tbekaert"><img src="https://avatars.githubusercontent.com/u/11920484?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Thomas Bekaert</b></sub></a><br /><a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=tbekaert" title="Code">💻</a></td>
<td align="center"><a href="https://mattbrannon.dev/"><img src="https://avatars.githubusercontent.com/u/36570183?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Matt Brannon</b></sub></a><br /><a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=mattbrannon" title="Documentation">📖</a></td>
</tr>
<tbody>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/idahogurl"><img src="https://secure.gravatar.com/avatar/787139c4c697cfc33cc422566a4ccf78?s=80&d=identicon?s=100" width="100px;" alt="Rebecca Vest"/><br /><sub><b>Rebecca Vest</b></sub></a><br /><a href="#question-idahogurl" title="Answering Questions">💬</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=idahogurl" title="Code">💻</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=idahogurl" title="Documentation">📖</a> <a href="#infra-idahogurl" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/issues?q=author%3Aidahogurl" title="Bug reports">🐛</a> <a href="#ideas-idahogurl" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/pulls?q=is%3Apr+reviewed-by%3Aidahogurl" title="Reviewed Pull Requests">👀</a> <a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=idahogurl" title="Tests">⚠️</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/tbekaert"><img src="https://avatars.githubusercontent.com/u/11920484?v=4?s=100" width="100px;" alt="Thomas Bekaert"/><br /><sub><b>Thomas Bekaert</b></sub></a><br /><a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=tbekaert" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://mattbrannon.dev/"><img src="https://avatars.githubusercontent.com/u/36570183?v=4?s=100" width="100px;" alt="Matt Brannon"/><br /><sub><b>Matt Brannon</b></sub></a><br /><a href="https://github.com/idahogurl/vs-code-prettier-eslint/commits?author=mattbrannon" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/cwilbur"><img src="https://avatars.githubusercontent.com/u/2566621?v=4?s=100" width="100px;" alt="Charlton Wilbur"/><br /><sub><b>Charlton Wilbur</b></sub></a><br /><a href="#maintenance-cwilbur" title="Maintenance">🚧</a></td>
</tr>
</tbody>
</table>

<!-- markdownlint-restore -->
Expand Down
43 changes: 22 additions & 21 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"version": "5.1.1",
"engines": {
"vscode": "^1.63.0",
"node": "^16.13.0"
"node": "^21.0.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not update this as it's not needed by the code or any of the packages.

},
"categories": [
"Formatters"
Expand Down Expand Up @@ -56,33 +56,34 @@
"contributors:generate": "all-contributors generate"
},
"devDependencies": {
"@auto-it/exec": "^10.42.2",
"@auto-it/first-time-contributor": "^10.42.2",
"@auto-it/released": "^10.42.2",
"@auto-it/upload-assets": "^10.42.2",
"@auto-it/vscode": "^10.42.2",
"@types/node": "^18.14.2",
"@vscode/test-electron": "^2.2.3",
"all-contributors-cli": "^6.24.0",
"auto": "^10.42.2",
"esbuild": "^0.16.14",
"esbuild-plugin-text-replace": "^1.2.0",
"eslint": "^8.31.0",
"@auto-it/exec": "^11.0.4",
"@auto-it/first-time-contributor": "^11.0.4",
"@auto-it/released": "^11.0.4",
"@auto-it/upload-assets": "^11.0.4",
"@types/node": "^20.8.6",
"@vscode/test-electron": "^2.3.5",
"@vscode/vsce": "^2.21.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this package needed? 🙂

"all-contributors-cli": "^6.26.1",
"auto": "^11.0.4",
"esbuild": "^0.19.4",
"esbuild-plugin-text-replace": "^1.3.0",
"eslint": "^8.52.0",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jest": "^27.2.0",
"jest": "^29.3.1",
"jest-environment-node": "^29.3.1",
"ovsx": "^0.7.1",
"prettier": "^2.8.1",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-jest": "^27.4.2",
"jest": "^29.7.0",
"jest-environment-node": "^29.7.0",
"ovsx": "^0.8.3",
"prettier": "^3.0.3",
"ts-node": "^10.9.1",
"typescript": "^4.9.5",
"typescript": "^5.2.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update TypeScript then you have to update the examples. Rather we do the least amount of changes

"@eslint/eslintrc": "^2.1.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this package needed?

"vsce": "^2.15.0"
},
"dependencies": {
"find-up": "^6.3.0",
"ignore": "^5.2.4",
"prettier-eslint": "^15.0.1"
"prettier-eslint": "^16.1.1"
},
"contributes": {
"configuration": {
Expand Down
2 changes: 0 additions & 2 deletions scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const textReplace = require('esbuild-plugin-text-replace');
const buildEnv = {
dev: false,
prod: false,
watch: false,
};
const nodeEnv = process.env.NODE_ENV.split(',');

Expand All @@ -23,7 +22,6 @@ const options = {
bundle: true,
sourcemap: buildEnv.dev,
minify: buildEnv.prod,
watch: buildEnv.watch,
plugins: [
textReplace({
include: /rule-tester/,
Expand Down
12 changes: 6 additions & 6 deletions test/suite/__snapshots__/extension.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
exports[`Extension Test Suite Format document using .prettierrc 1`] = `
"/* eslint-disable */
const options = {
first: "hello, world",
first: 'hello, world',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indicates that there is a bug as the snapshots shouldn't change between versions

second: true,
internationalizing: true,
}
};

export { options }
export { options };
"
`;

Expand All @@ -25,11 +25,11 @@ export { options };

exports[`Extension Test Suite setting "prettierLast" makes prettier run last 1`] = `
"const options = {
first: "hello, world",
first: 'hello, world',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indicates that there is a bug as the snapshots shouldn't change between versions

second: true,
internationalizing: true,
}
};

export { options }
export { options };
"
`;
Loading
Loading