-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/quickster footstep provider #527
base: develop
Are you sure you want to change the base?
Conversation
…fraction and pole
…te machine to go to TO_STANDING
balanceManager.computeICPPlan(); | ||
} | ||
|
||
private boolean haveWeEntered = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by this boolean. Isn't whether or not you are executing the method inside onEntry()
enough information to set firstTick
in the method? Why are haveWeEntered
and firstTick
both in handleNewFootstep()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's probably a better way to do this whole thing. They don't exactly convey the same information, since first tick could be false if it is the second+ tick or if it has not entered the state yet, and that distinction is important. It is possible for the method that relies on this boolean (handleNewFootstep()
) to be called without entering the state (WalkingSingleSupportState
) because I have this method tied to a listener in another class (WalkingMessageHandler
), and the class that this method belongs to is instantiated twice, once for each leg. So it is possible for this to be called by the listener even if the class (and therefore single support of the proper leg) has not been called.
The thing is, this is probably redundant because I later ended up adding a check to make sure that we only proceed with the handleNewFootstep()
method if we are on the proper side of the robot. So I can probably delete the logic that relies on haveWeEntered
This is the initial groundwork for the implementation of Quickster's footstep calculator into the regular walking controller via the CSG (in step generator thread).
Tests included in this PR:
The next steps include: