Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated API Version Mismatch wording #8227

Conversation

michaelchadwick
Copy link
Contributor

Refs ilios/ilios#5430

  • Removed a render modifier.
  • Fixed a typo in the English translation message
  • Updated the Spanish translation to match English/French

@@ -14,7 +14,7 @@ general:
allMaterials: All Materials
allWeeks: All Weeks
apiVersionMismatch: API Version Mismatch
apiVersionMismatchDetails: "This is usually a temporary error in your browser; Ilios is in read-only mode until it resolved. If updating does not help, please notify an administrator or technical owner of the system regarding this error. You may also wish to try a different browser."
apiVersionMismatchDetails: "This is usually a temporary error in your browser; Ilios is in read-only mode until it is resolved. If updating does not help, please notify an administrator or technical owner of the system regarding this error. You may also wish to try a different browser."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

stopfstedt
stopfstedt previously approved these changes Nov 22, 2024
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelchadwick michaelchadwick marked this pull request as ready for review November 22, 2024 18:25
@michaelchadwick michaelchadwick force-pushed the frontend-5430-fix-api-version-misleading-message branch from 85b948e to a0b506e Compare November 22, 2024 18:32
@stopfstedt stopfstedt self-assigned this Nov 22, 2024
@stopfstedt stopfstedt added the run ui tests Run the expensive UI tests label Nov 22, 2024
@stopfstedt stopfstedt self-requested a review November 22, 2024 19:33
@stopfstedt stopfstedt merged commit f554b85 into ilios:master Nov 22, 2024
42 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5430-fix-api-version-misleading-message branch November 22, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants