Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated API Version Mismatch wording #8227

Merged
merged 4 commits into from
Nov 22, 2024
Merged

updated API Version Mismatch wording #8227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9795aff
removed render modifier
michaelchadwick Nov 14, 2024
85588d8
fixed typo in English translation
michaelchadwick Nov 14, 2024
f861521
updated Spanish translation to match wording of English/French transl…
michaelchadwick Nov 14, 2024
a0b506e
updated lint-todo
michaelchadwick Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/ilios-common/.lint-todo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|fb439ee6b510cea24e2b47eda775aee573be6e1e|1731542400000|1762646400000|1793750400000|addon/components/api-version-notice.hbs
add|ember-template-lint|no-at-ember-render-modifiers|25|6|25|6|1ef231a97c0ec761eaafb3e76093515e5523ff27|1731542400000|1762646400000|1793750400000|addon/components/choose-material-type.hbs
add|ember-template-lint|no-at-ember-render-modifiers|26|6|26|6|df94e6558ff62dea69f6f656f668f29b56bcc378|1731542400000|1762646400000|1793750400000|addon/components/choose-material-type.hbs
add|ember-template-lint|no-at-ember-render-modifiers|7|2|7|2|1a2522cd1202904fb09a6e811dec6b46d8189ab3|1731542400000|1762646400000|1793750400000|addon/components/daily-calendar-event.hbs
Expand Down
1 change: 0 additions & 1 deletion packages/ilios-common/addon/components/api-version-notice.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
class="api-version-notice {{if this.mismatched "mismatch"}}"
hidden={{not this.mismatched}}
role={{if this.mismatched "alert" false}}
{{did-insert (perform this.check)}}
data-test-load-finished={{this.check.lastSuccessful.value}}
data-test-api-version-notice
>
Expand Down
5 changes: 5 additions & 0 deletions packages/ilios-common/addon/components/api-version-notice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ export default class ApiVersionNoticeComponent extends Component {
@tracked countdownToUpdate = null;
@tracked showReloadButton = false;

constructor() {
super(...arguments);
this.check.perform();
}

reload() {
window.location.reload();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ilios-common/translations/en-us.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ general:
allMaterials: All Materials
allWeeks: All Weeks
apiVersionMismatch: API Version Mismatch
apiVersionMismatchDetails: "This is usually a temporary error in your browser; Ilios is in read-only mode until it resolved. If updating does not help, please notify an administrator or technical owner of the system regarding this error. You may also wish to try a different browser."
apiVersionMismatchDetails: "This is usually a temporary error in your browser; Ilios is in read-only mode until it is resolved. If updating does not help, please notify an administrator or technical owner of the system regarding this error. You may also wish to try a different browser."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

assignedTerms: Assigned Terms
associatedGroups: Associated Groups
attendanceIs_Required_: "Attendance is '<strong><em>'required'</em></strong>'"
Expand Down
2 changes: 1 addition & 1 deletion packages/ilios-common/translations/es.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ general:
allMaterials: Todos los Materiales
allWeeks: Todas las Semanas
apiVersionMismatch: Incompatibilidad de versión de API
apiVersionMismatchDetails: "Este interfaz de usuario no corresponde a la versión del API con el cual se comunica. Por favor notifique a un administrador o el dueño técnico del sistema con respecto a este error '<em>'inmediatamente'</em>', no puede trabajar con Ilios hasta que esto ha sido resuelto"
apiVersionMismatchDetails: "Por lo general, se trata de un error temporal de su navegador; Ilios está en modo de solo lectura hasta que se resuelva. Si la actualización no soluciona el problema, notifique a un administrador o al propietario técnico del sistema sobre este error. También puede probar con otro navegador."
assignedTerms: Términos asignados
associatedGroups: Grupos Associados
attendanceIs_Required_: "Se '<strong><em>'require'</em></strong>' asistencia"
Expand Down