-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new slots and enums to Study; add new class Dataset #163
Conversation
definition_uri: include:studyDesign | ||
description: Overall design of study, including whether it is longitudinal and whether family members/unrelated controls are also enrolled | ||
title: Study Design | ||
range: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any use cases to query or filter for data based on studyDesign
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not currently, but it might be nice to be able to search for longitudinal studies, or family studies. This field (and the Selection Criteria field) will probably be used more heavily for clinical trials, so there might be more opportunities to standardize when we have more trials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, from past modeling and ontology work on omics data I am more used to seeing study design as an enum to be able to filter and query data. Are the current thoughts that the range may change to an enum in the future and any past data re-annotated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lopierra if this field does change to an enum in the future and previous data needs to be re-annotated, can we document this in the project plan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think several fields should be changed to enums in the future. We're still determining where to document our plans, but at the very least it should be a github issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've listed the fields that need your help in #108
Yes, it's just a string for now so the portal team can build the prototype pages. We should be working on enums for several of the fields.
From: Trish Whetzel ***@***.***>
Sent: Thursday, March 21, 2024 12:27 PM
To: include-dcc/include-linkml ***@***.***>
Cc: Lo, Pierrette ***@***.***>; Author ***@***.***>
Subject: Re: [include-dcc/include-linkml] Add new slots and enums to Study; add new class Dataset (PR #163)
[External Email - Use Caution]
@twhetzel commented on this pull request.
________________________________
In src/linkml/include_study.yaml<#163 (comment)>:
+ definition_uri: include:participantLifespanStage
+ description: Focus age group(s) of the study population; pipe-separated if multiple
+ title: Participant Lifespan Stage
+ range: enum_participantLifespanStage
+ required: true
+ multivalued: true
+ selectionCriteria:
+ definition_uri: include:selectionCriteria
+ description: Brief description of inclusion and/or exclusion criteria for the study
+ title: Selection Criteria
+ range: string
+ studyDesign:
+ definition_uri: include:studyDesign
+ description: Overall design of study, including whether it is longitudinal and whether family members/unrelated controls are also enrolled
+ title: Study Design
+ range: string
Ok, from past modeling and ontology work on omics data I am more used to seeing study design as an enum to be able to filter and query data. Are the current thoughts that the range may change to an enum in the future and any past data re-annotated?
-
Reply to this email directly, view it on GitHub<#163 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIERJPAGRRNDAB35BPXXL3DYZMQ53AVCNFSM6AAAAABFANFGAKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJTGA4DGNJSGU>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
@@ -7,6 +7,9 @@ prefixes: | |||
linkml: | |||
prefix_prefix: linkml | |||
prefix_reference: https://w3id.org/linkml/ | |||
mesh: | |||
prefix_prefix: mesh | |||
prefix_reference: http://id.nlm.nih.gov/mesh/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @madanucd!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one open question, but otherwise looks good to me.
closes #59