-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-15081 Patternfly 5 update #387
Conversation
a484cbb
to
7501f40
Compare
7501f40
to
517368f
Compare
Background image issue raise patternfly/patternfly#5806 |
519aa2f
to
a47dbfc
Compare
b34c78a
to
4c3d9f3
Compare
4c3d9f3
to
25f02c8
Compare
dc28a16
to
eb9e91c
Compare
@karesti @andyuk1986 this PR is ready for final review |
Added custom CSS to solve this |
@dpanshug added a commit. Popover was broken, I fixed that and a couple small unrelated changes introduced with the UX refactoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I fixed the error with the Popover
Please double check the patternfly v5 css properties that were renamed
@andyuk1986 Can you please re-review this, some tests are failing. |
4662f6b
to
26d7bef
Compare
@dpanshug I'm on the review and some fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpanshug if you plan to update or do follow up PR that are not mandatory for this one, please, create JIRAS with the explanation and content of those changes to be done. If you can't do it, I or somebody else will take care of those changes.
Created JIRA's for those, ISPN-15146 ISPN-15145 |
@andyuk1986 the test passed here so I merged, but it's failing in main |
Hey @karesti , I was on PTO. Will look at the tests in main. |
https://issues.redhat.com/browse/ISPN-15081
Summary of changes:
Node and npm Update:
github/pull_request.yaml
andpom.xml
.Patternfly Update:
React Version Upgrade:
Other Package Updates: Reviewed and updated all other packages for compatibility and enhancements, except the following:
a. css-loader:
- Requires adjustments to webpack configuration.
- Another issue for it ISPN-15145
b. react-router-dom:
- Requires modifications to router config throughout the project.
- Another issue for it ISPN-15146
c. monaco-editor & react-monaco-editor:
- Can't update due to PF5's reliance on outdated dependencies.
Separately modified background image on Welcome and About page.