Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-15081 Patternfly 5 update #387

Merged
merged 9 commits into from
Sep 4, 2023

Conversation

dpanshug
Copy link
Collaborator

@dpanshug dpanshug commented Aug 4, 2023

https://issues.redhat.com/browse/ISPN-15081

Summary of changes:

  1. Node and npm Update:

    • Updated Node.js version to v18.17.0 and npm to 9.6.7 in github/pull_request.yaml and pom.xml.
  2. Patternfly Update:

    • Upgraded patternfly packages to latest versions (PF5) .
  3. React Version Upgrade:

    • Transitioned to React 18.
  4. Other Package Updates: Reviewed and updated all other packages for compatibility and enhancements, except the following:

    a. css-loader:
    - Requires adjustments to webpack configuration.
    - Another issue for it ISPN-15145

    b. react-router-dom:
    - Requires modifications to router config throughout the project.
    - Another issue for it ISPN-15146

    c. monaco-editor & react-monaco-editor:
    - Can't update due to PF5's reliance on outdated dependencies.

  5. Separately modified background image on Welcome and About page.

@dpanshug dpanshug force-pushed the ISPN-15081-update-packages branch from a484cbb to 7501f40 Compare August 4, 2023 13:01
@andyuk1986 andyuk1986 force-pushed the ISPN-15081-update-packages branch from 7501f40 to 517368f Compare August 4, 2023 15:32
@dpanshug dpanshug marked this pull request as ready for review August 4, 2023 15:36
@dpanshug
Copy link
Collaborator Author

dpanshug commented Aug 7, 2023

Background image issue raise patternfly/patternfly#5806

@dpanshug dpanshug force-pushed the ISPN-15081-update-packages branch 8 times, most recently from 519aa2f to a47dbfc Compare August 10, 2023 08:43
@dpanshug dpanshug force-pushed the ISPN-15081-update-packages branch 11 times, most recently from b34c78a to 4c3d9f3 Compare August 10, 2023 11:25
@dpanshug dpanshug force-pushed the ISPN-15081-update-packages branch from 4c3d9f3 to 25f02c8 Compare August 10, 2023 13:18
.cache_1b2yk2k Outdated Show resolved Hide resolved
@dpanshug dpanshug force-pushed the ISPN-15081-update-packages branch from dc28a16 to eb9e91c Compare August 11, 2023 05:53
@dpanshug dpanshug requested review from karesti and andyuk1986 August 11, 2023 06:17
@dpanshug
Copy link
Collaborator Author

@karesti @andyuk1986 this PR is ready for final review

@dpanshug
Copy link
Collaborator Author

Background image issue raise patternfly/patternfly#5806

Added custom CSS to solve this

@dpanshug dpanshug removed the preview label Aug 11, 2023
@karesti
Copy link
Collaborator

karesti commented Aug 11, 2023

@dpanshug added a commit. Popover was broken, I fixed that and a couple small unrelated changes introduced with the UX refactoring

Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I fixed the error with the Popover

Please double check the patternfly v5 css properties that were renamed

@dpanshug
Copy link
Collaborator Author

@andyuk1986 Can you please re-review this, some tests are failing.

@dpanshug dpanshug force-pushed the ISPN-15081-update-packages branch from 4662f6b to 26d7bef Compare September 2, 2023 17:09
@dpanshug dpanshug requested a review from karesti September 2, 2023 17:32
@karesti
Copy link
Collaborator

karesti commented Sep 4, 2023

@dpanshug I'm on the review and some fixes

@karesti karesti removed their request for review September 4, 2023 07:43
@karesti karesti self-requested a review September 4, 2023 12:01
Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpanshug if you plan to update or do follow up PR that are not mandatory for this one, please, create JIRAS with the explanation and content of those changes to be done. If you can't do it, I or somebody else will take care of those changes.

@dpanshug
Copy link
Collaborator Author

dpanshug commented Sep 4, 2023

@dpanshug if you plan to update or do follow up PR that are not mandatory for this one, please, create JIRAS with the explanation and content of those changes to be done. If you can't do it, I or somebody else will take care of those changes.

Created JIRA's for those, ISPN-15146 ISPN-15145

@karesti karesti merged commit 529e416 into infinispan:main Sep 4, 2023
1 check passed
@karesti
Copy link
Collaborator

karesti commented Sep 4, 2023

@andyuk1986 the test passed here so I merged, but it's failing in main

@andyuk1986
Copy link
Collaborator

Hey @karesti , I was on PTO. Will look at the tests in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants