feat: add stargate query support for staking related queries #249
Conversation
WalkthroughWalkthroughThe recent updates enhance the Changes
Sequence Diagram(s)sequenceDiagram
participant AppKeeper
participant MoveKeeper
participant QueryWhitelist
AppKeeper->>QueryWhitelist: Initialize query paths
QueryWhitelist-->>AppKeeper: Provide query paths
AppKeeper->>MoveKeeper: Create with query whitelist
MoveKeeper->>MoveKeeper: Handle incoming staking queries
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 40.56% 40.61% +0.05%
==========================================
Files 264 264
Lines 25059 25081 +22
==========================================
+ Hits 10164 10186 +22
Misses 13326 13326
Partials 1569 1569
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/keepers/keepers.go (2 hunks)
Additional comments not posted (3)
app/keepers/keepers.go (3)
621-641: Well-structured initialization ofqueryWhitelist.The use of
movetypes.ProtoSetto define request and response types for specific Stargate query paths is a good approach. This setup enhances the configurability and security of theMoveKeeperby ensuring only whitelisted queries are processed.
Line range hint
643-661:
EnhancedMoveKeeperinitialization with query whitelisting.The inclusion of
WithVMQueryWhitelist(queryWhitelist)in theMoveKeeperinitialization is a commendable improvement. It allows theMoveKeeperto efficiently manage and secure staking-related queries by leveraging the defined whitelist.
Line range hint
600-700:
Overall improvements inNewAppKeeperfunction.The modifications to the
NewAppKeeperfunction, including the introduction ofqueryWhitelistand the enhancedMoveKeeperinitialization, align well with the PR objectives. These changes effectively integrate Stargate query support for staking-related operations, enhancing the system's capabilities.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...