Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teerex refactor 2 #191

Merged
merged 25 commits into from
Jul 10, 2023
Merged

teerex refactor 2 #191

merged 25 commits into from
Jul 10, 2023

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Jul 7, 2023 •
edited
Loading

closes #186 #183 #152

breaking changes:

  • ShardStatus will replace WorkerForShard logic
  • remove skip-ias
  • introduce MultiEnclave

non-breaking changes:

  • no automatic garbage collection OnTimestamp anymore. lazy dispatchable introduced

@brenzi
Copy link
Contributor Author

brenzi commented Jul 7, 2023

I just realize that refactoring the sidechain pallet will likely require to solve #183 because we currently only let the first ever registered validateer finalize and the move to a storage map no longer let's us derive an order

@brenzi
Copy link
Contributor Author

brenzi commented Jul 8, 2023

breaking change: ShardStatus will replace WorkerForShard logic

@brenzi brenzi marked this pull request as ready for review July 8, 2023 06:12
clangenb
clangenb reviewed Jul 8, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed everything except for the tests (need a break for attentive reviewing). Looks good so far!

primitives/teerex/Cargo.toml Show resolved Hide resolved
primitives/teerex/src/lib.rs Outdated Show resolved Hide resolved
teerex/src/lib.rs Outdated Show resolved Hide resolved
teerex/src/lib.rs Show resolved Hide resolved
teerex/src/lib.rs Show resolved Hide resolved
teerex/src/lib.rs Show resolved Hide resolved
teerex/src/lib.rs Outdated Show resolved Hide resolved
teerex/src/lib.rs Outdated Show resolved Hide resolved
teerex/src/lib.rs Outdated Show resolved Hide resolved
teerex/src/lib.rs Outdated Show resolved Hide resolved
@brenzi brenzi requested a review from clangenb July 8, 2023 13:41
This was referenced Jul 8, 2023
Closed
Closed
Merged
clangenb
clangenb approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me except for one detail, but I shall approve already. :)

teerex/src/lib.rs Outdated Show resolved Hide resolved
@brenzi brenzi merged commit a20da42 into master Jul 10, 2023
@brenzi brenzi mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[teerex] unify dispatchables for enclave registration
2 participants
@brenzi @clangenb