[SYCL][Reduction] Fix identityless reductions with unwritten reducers #8709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes reducers to use a new object for holding results, namely ReducerElement. This new object either holds a value directly or holds an optional value. The latter is used for identityless reductions to allow cases where the user functors did not write a value into the given reducer and as such the reducer's value should be discounted. This new element is used inside reductions that support identityless to correctly propagate potentially missing values throughout. Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1672 |
This was referenced Mar 21, 2023
…ss_range_reductions
Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm-test-suite#1672 |
…ss_range_reductions
This commit moves the E2E test changes from the following PRs: * intel/llvm-test-suite#1659 * intel/llvm-test-suite#1672 * intel/llvm-test-suite#1697 Signed-off-by: Larsen, Steffen <[email protected]>
…ss_range_reductions
aelovikov-intel
approved these changes
Mar 31, 2023
…ss_range_reductions
…ss_range_reductions
Signed-off-by: Larsen, Steffen <[email protected]>
againull
pushed a commit
to againull/llvm
that referenced
this pull request
Apr 4, 2023
…intel#8709) This commit changes reducers to use a new object for holding results, namely ReducerElement. This new object either holds a value directly or holds an optional value. The latter is used for identityless reductions to allow cases where the user functors did not write a value into the given reducer and as such the reducer's value should be discounted. This new element is used inside reductions that support identityless to correctly propagate potentially missing values throughout. --------- Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes reducers to use a new object for holding results, namely ReducerElement. This new object either holds a value directly or holds an optional value. The latter is used for identityless reductions to allow cases where the user functors did not write a value into the given reducer and as such the reducer's value should be discounted.
This new element is used inside reductions that support identityless to correctly propagate potentially missing values throughout.