Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): test status and not body #221

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix(tar): test status and not body #221

merged 2 commits into from
Aug 9, 2024

Conversation

gammazero
Copy link
Contributor

The error message in boxo was fixed to say "not allowed" instead of "now allowed". The message that the gateway conformance test looks for needs to match.

The error message in boxo was fixed to say "not allowed" instead of "now allowed". The message that the gateway conformance test looks for needs to match.
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1308 0 0 0

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1308 0 0 0

Copy link
Contributor

github-actions bot commented Aug 9, 2024

v0.6.2

Changed

  • Relaxed negative test of TAR response #221

@lidel lidel changed the title Look for correct error message fix(tar): test status and not body Aug 9, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! refactored so this can be released as a v6 patch

(fleek error is not related to this PR - we have a website which no longer builds correctly, but that does not impact test suite, will fix in spare time in future PRs)

@lidel lidel merged commit b65f03b into main Aug 9, 2024
10 of 12 checks passed
@lidel lidel deleted the fix/error-message branch August 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants