Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): test status and not body #221

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix(tar): test status and not body #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bebff8
Look for correct error message
gammazero Aug 9, 2024
65dfafc
refactor: make test backward-compatible
lidel Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.6.2] - 2024-08-09
### Changed
- Relaxed negative test of TAR response [#221](https://github.com/ipfs/gateway-conformance/pull/221)

## [0.6.1] - 2024-07-29
### Changed
- Support meaningful `Cache-Control` on generated UnixFS directory listing responses on `/ipfs` namespace
Expand Down
5 changes: 2 additions & 3 deletions tests/path_gateway_tar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,12 @@ func TestTar(t *testing.T) {
},
{
Name: "GET TAR with relative paths outside root fails",
Hint: "relative UnixFS paths outside the root are not allowed",
Request: Request().
Path("/ipfs/{{cid}}", outsideRootCID).
Query("format", "tar"),
Response: Expect().
Body(
Contains("relative UnixFS paths outside the root are now allowed"),
),
StatusBetween(400, 599),
},
{
Name: "GET TAR with relative paths inside root works",
Expand Down
Loading