Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): redirect /ipns/b58mh to /ipns/cidb36 #9785

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 31, 2023

Closes #9749

Do not use base58-encoded multihash peer IDs for IPNS tests. Required for ipfs/boxo#236, otherwise tests will fail since we will be redirecting. Redirection tests are included in the referenced PR.

@hacdias hacdias force-pushed the issue/9749 branch 2 times, most recently from c0273a3 to d17449d Compare March 31, 2023 13:47
@hacdias hacdias self-assigned this Mar 31, 2023
@hacdias hacdias requested a review from lidel March 31, 2023 14:04
@hacdias hacdias marked this pull request as ready for review March 31, 2023 14:04
@hacdias hacdias force-pushed the issue/9749 branch 3 times, most recently from 6ae1070 to ebf0622 Compare April 5, 2023 12:09
test/cli/gateway_test.go Outdated Show resolved Hide resolved
@hacdias hacdias force-pushed the issue/9749 branch 2 times, most recently from e9b4323 to 1ecb28b Compare April 6, 2023 08:23
@hacdias hacdias requested a review from lidel April 6, 2023 08:34
@hacdias hacdias requested a review from a team as a code owner April 11, 2023 08:32
@hacdias hacdias force-pushed the issue/9749 branch 3 times, most recently from 58f61aa to fc6faef Compare April 25, 2023 08:58
@hacdias hacdias requested a review from Jorropo May 2, 2023 12:08
@hacdias hacdias force-pushed the issue/9749 branch 3 times, most recently from ca95947 to 6f7a792 Compare May 10, 2023 10:52
@lidel lidel self-assigned this May 11, 2023
@lidel lidel changed the title fix: do not use b58mh peer id for ipns test feat(gateway): redirect /ipns/b58mh to /ipns/cidb36 May 16, 2023
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, lgtm.

@lidel lidel merged commit 13c3796 into master May 16, 2023
@lidel lidel deleted the issue/9749 branch May 16, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Gateway support for signed IPNS records doesn't work with raw base58 PeerIDs
2 participants