Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureSource: remove need to specify id_field #61

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Jan 2, 2024

No description provided.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (9096b8e) 51.26% compared to head (f377115) 51.36%.

Files Patch % Lines
src/gdal_dataset_wrapper.cpp 48.57% 18 Missing ⚠️
src/gdal_feature.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   51.26%   51.36%   +0.09%     
==========================================
  Files          73       72       -1     
  Lines       11747    11773      +26     
==========================================
+ Hits         6022     6047      +25     
- Misses       5725     5726       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbaston dbaston merged commit 71caf60 into isciences:master Jan 3, 2024
14 checks passed
@dbaston dbaston deleted the featuresource-remove-id branch January 3, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant