-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD 1.1 - basic reset to REC-ConeSearch-1.03 w/ Errata fixes #55
Conversation
Following DAL running meeting on ConeSearch I'm unsure on who should review this. Maybe wait DAL session 1 at the Nov.'23 Interop (couple of days) before acting here. |
I already had a look at it. It seems ok to me. But sure, I expected something like "wait for the DAL 1 session before doing anything here" 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While waiting for your answers (especially for my comment about the editor), I just send a comment in this review. But actually, I already approve it.
ConeSearch.tex
Outdated
\author[http://www.ivoa.net/twiki/bin/view/IVOA/AlexSzalay]{Alex Szalay} | ||
\author[http://www.ivoa.net/twiki/bin/view/IVOA/RoyWilliams]{Roy Williams} | ||
|
||
\editor{Marco Molinaro, Ada Nebot, Raymond Plante} | ||
\editor{Ray Plante} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are still editing the document, I think, Marco, that you can add yourself as editor and author. Yes, it is a revert operation, but you still have changes few things not so minor (e.g. errata).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done in f30b86b
develop standards and infrastructure that enable VO applications. | ||
|
||
The ConeSearch-1.1 revision has been developed and supported under the | ||
ASTERICS and ESCAPE projects (funded by the European Commission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new version of the ConeSearch, now being re-written differently, still
been developed and supported under the ASTERICS and ESCAPE projects?
I would rather say it has been started or initiated by these projects.
Anyway, no strong opinion here ; I was just wondering...
In any case, the corresponding ChangeLog could/should stay in this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, check whether c08324d works.
@gmantele : I worked on the comments and fixed the github action. Please, review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all good to me 👍
This is the base to restart a WD revision for version 1.1.
The idea is that: if this gets merged, it will form the new WD to start agreed changes: