Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid some NPE on generateSnippet #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid some NPE on generateSnippet #192

wants to merge 1 commit into from
+13 −2

Conversation

chcg
Copy link

@chcg chcg commented Dec 2, 2024 •
edited
Loading

fix #190

  • added nullpointer checks
  • consolidation of usage @NonNull vs. @Nonnull

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@chcg chcg requested a review from a team as a code owner December 2, 2024 13:01
@chcg chcg changed the title avoid NPE on generateSnippet avoid some NPE on generateSnippet Dec 2, 2024
@chcg
- added nullpointer checks
382f093 
- consolidation of usage @nonnull vs. @nonnull
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imonteroperez imonteroperez imonteroperez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE on pipeline generateSnippet
2 participants
@chcg @imonteroperez