Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for API change in JUnit. #127

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mdealer
Copy link
Contributor

@mdealer mdealer commented Jul 23, 2024

Improve compatibility in advance to jenkinsci/junit-plugin#625

Fixes
java.lang.NoSuchMethodError: 'java.util.List hudson.tasks.junit.ClassResult.getChildren()'

Testing done

Unit Tests run locally

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja merged commit 7a2b498 into jenkinsci:main Jul 23, 2024
16 checks passed
@jglick
Copy link
Member

jglick commented Jul 23, 2024

Did you actually try this in PCT, which compiles a plugin’s tests against its declared dependencies but then runs them against its updated dependencies? I suspect you would still get an error.

@timja
Copy link
Member

timja commented Jul 23, 2024

I'm trying in a min the update was just merged: jenkinsci/bom#3395 (could have done pre-merge but looked safe to me)

@timja
Copy link
Member

timja commented Jul 23, 2024

@jglick
Copy link
Member

jglick commented Jul 23, 2024

I guess it does not much matter, since this is released first, and it is only test code.

@jglick
Copy link
Member

jglick commented Jul 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants