feat: add types to package #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
requested changes
Nov 4, 2024
| environments: { | ||
| globals: { | ||
| globals: { | ||
| [key: string]: boolean; |
There was a problem hiding this comment.
note: ideally this should be Linter.GlobalConf, but that was introduced in @types/eslint@9
mskelton
force-pushed
the
mskelton/add-types
branch
from
789d4ec
to
a28e9d8
Compare
|
@G-Rath Updated per your suggestions |
G-Rath
reviewed
Nov 4, 2024
mskelton
force-pushed
the
mskelton/add-types
branch
from
a28e9d8
to
1bdda54
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
# [28.9.0](v28.8.3...v28.9.0) (2024-11-05) ### Features * add TypeScript types ([#1667](#1667)) ([1ce1258](1ce1258))
|
Apparently there's a recent issue with The release was still successful, so this has gone out in v28.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1469
I opted to generate the types manually with a hard coded
index.d.tsfile given that the types are very straightforward and the result works much better with typescript-eslint in my experience vs simply relying ontscgenerated types.