This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful when completely custom navigation is required, like presenting a modal from
WKUIDelegate.webView(_:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:)
, for example:That last line is important - if we don't have access to the currently visible navigation controller the app can crash. For example, if we try to present this alert on the main/root controller while a modal is displayed.
I like this approach because it gives the developer full control over when/how they want to present the dialog. But it also requires them to implement both this and the
confirm()
function.Part of me thinks that both of these should be included directly in Turbo Navigator. But then if someone wants to do something entirely custom with
WKUIDelegate
I'm not sure how to expose that.