Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility and silent mode #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve compatibility and silent mode #11

wants to merge 2 commits into from

Conversation

danijelt
Copy link

First commit improves compatibility (discussed in issue #7) with units that don't respond to RH, RI, Ra and RL queries. This should be a minimally intrusive way to do it, by moving them to a "failable" queries list. This way, we now always expect response from F9 (all of them should according to what I found online), and for units that don't return their external temperature there, we'll get it from Ra query anyway.

Second commit adds silent fan mode. Nothing special, just another value in enum. Tested and working.

This was referenced Aug 13, 2023
Open
Closed
joshbenner
joshbenner requested changes Aug 14, 2023
View reviewed changes
components/daikin_s21/s21.cpp Outdated Show resolved Hide resolved
@danijelt
improve compatibility
0aabc8e 
Some units don't respond to RH and Ra queries used to fetch inside and
outside temperatures, along with some other queries.

This commit fixes the compatibility by trying to read the inside and
outside temperatures with both the F9 or RH/Ra queries. Since we don't
know which of these can fail, they are moved to a separate loop that
won't affect the ready state, but it still fills all the gaps that can
occur due to not responding to some query.
@danijelt
add silent fan mode
7c890ee
@dhbfischer
Copy link

Tested and working on my FTXC-B. Didn't got the main branch working due to unknown queries: RH, RI, Ra, RL.
F9 does work and gives me indeed an indoor and outdoor temperature.

I've tested also some "experimental" queries and "F2", "F3", "F4", "M" seem to work in addition to "F1", "F5", "Rd".
I can possibly check in the future.
Currently on my FTXC-B I don't have the coil temp and fan speed (rpm), possibly this isn't an option on mine either.

[14:02:28][D][daikin_s21:367]: ** UNKNOWN QUERIES **
[14:02:28][D][daikin_s21:294]: S21: G2 -> 4:\x80\x80 (4)
[14:02:28][D][daikin_s21:341]: Unknown response G2 -> "4:\x80\x80"
[14:02:28][D][daikin_s21:294]: S21: G3 -> 0000 (4)
[14:02:28][D][daikin_s21:341]: Unknown response G3 -> "0000"
[14:02:28][D][daikin_s21:294]: S21: G4 -> 0 \x800 (4)
[14:02:28][D][daikin_s21:341]: Unknown response G4 -> "0 \x800"
[14:02:28][D][daikin_s21:261]: NAK from S21 for RN query
[14:02:28][D][daikin_s21:261]: NAK from S21 for RX query
[14:02:28][D][daikin_s21:261]: NAK from S21 for RD query
[14:02:28][D][daikin_s21:294]: S21: M -> 1344 (4)
[14:02:28][D][daikin_s21:341]: Unknown response M -> "1344"
[14:02:29][D][daikin_s21:294]: S21: G\x00\x00\x00 -> \x00\x00 (2)
[14:02:29][D][daikin_s21:341]: Unknown response G\x00\x00\x00 -> "\x00\x00"

@dhbfischer
Copy link

@joshbenner what about this pull request? Can it be merged? The change request seems to be fixed.

@wrouesnel wrouesnel mentioned this pull request Dec 20, 2023
Open
@wittimagic
Copy link

wittimagic commented Dec 5, 2024 •
edited
Loading

Availability of the silent mode is a must have for me.
@joshbenner Will this be merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbenner joshbenner joshbenner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danijelt @dhbfischer @wittimagic @joshbenner