Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.2 #98

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Rails 7.2 #98

merged 1 commit into from
Aug 10, 2024

Conversation

yosiat
Copy link
Contributor

@yosiat yosiat commented Aug 10, 2024

Issue #97

Copy link
Collaborator

@dmytro-savochkin dmytro-savochkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One super small comment.

gem "activerecord", "~> 7.2"
gem "activesupport", "~> 7.2"
gem "standard", "~> 1.16"
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a newline here? It breaks Standard linter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, nevermind, I am gonna merge as is because I still wanna do some other changes, gonna change this as well.

@dmytro-savochkin dmytro-savochkin merged commit 8d28065 into jpignata:master Aug 10, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants