Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7.2 #98

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Rails 7.2 #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ jobs:
fail-fast: false
matrix:
include:
- ruby: '3.2'
rails: '7.2'
- ruby: '3.1'
rails: '7.2'
- ruby: '3.2'
rails: '7.1'
- ruby: '3.1'
Expand Down
6 changes: 6 additions & 0 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,9 @@ appraise "activerecord-7.1" do
gem "activesupport", "~> 7.1"
gem "standard", "~> 1.16"
end

appraise "activerecord-7.2" do
gem "activerecord", "~> 7.2"
gem "activesupport", "~> 7.2"
gem "standard", "~> 1.16"
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a newline here? It breaks Standard linter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, nevermind, I am gonna merge as is because I still wanna do some other changes, gonna change this as well.

9 changes: 9 additions & 0 deletions gemfiles/activerecord_7.2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "activerecord", "~> 7.2"
gem "activesupport", "~> 7.2"
gem "standard", "~> 1.16"

gemspec path: "../"
4 changes: 2 additions & 2 deletions temping.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ Gem::Specification.new do |s|

s.required_ruby_version = ">= 2.5"

s.add_dependency "activerecord", ">= 6.0", "< 7.2"
s.add_dependency "activesupport", ">= 6.0", "< 7.2"
s.add_dependency "activerecord", ">= 6.0", "< 7.3"
s.add_dependency "activesupport", ">= 6.0", "< 7.3"

s.add_development_dependency "appraisal", "~> 2.2"

Expand Down
Loading