Update tutorial readme melodic #429
Conversation
HiroIshida
force-pushed
the
update-tutorial-readme-melodic
branch
from
a38fcd8
to
fe8f7ab
Compare
| mkdir -p ~/catkin_ws/src && cd ~/catkin_ws | ||
| catkin init | ||
| wstool init src | ||
| wstool merge -t src https://raw.githubusercontent.com/jsk-ros-pkg/jsk_pr2eus/tree/master/pr2eus_tutorials/pr2eus_tutorials.rosinstall |
There was a problem hiding this comment.
@HiroIshida Why we install source after sudo apt install ros-$ROS_DISTRO-pr2eus-tutorials at https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/429/files#diff-d9d1ac6a1d0d20412ad36c7e287f0a27R13
There was a problem hiding this comment.
In the original README file, the both section Using pre-build package and Using source package do exit, so I just put both of them with no thought. In the original one, I guess the it was written like that so that a user can select from the two options.
However, I tried the option Using pre-build package, then when run roslaunch pr2eus_tutorials pr2_tabletop_sim.launch physics:=dart of here, I got the following error:
root@0628585147d9:/home$ roslaunch pr2eus_tutorials pr2_tabletop_sim.launch physics:=dart
... logging to /root/.ros/log/1c0079ba-7a99-11ea-b073-0242ac110004/roslaunch-0628585147d9-28828.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
Resource not found: pr2_gazebo
ROS path [0]=/opt/ros/melodic/share/ros
ROS path [1]=/opt/ros/melodic/share
The traceback for the exception was written to the log file
Apparently, pr2_gazebo package is missed in the apt-released version. Also, another command from here does not work because pr2-tabletop-object-grasp.l does not exist in the package.
Thus I now conclude to remove the option of Using pre-build package.
There was a problem hiding this comment.
please make sure that you ran rosdep install ... command, pr2_gazebo is set run_depends at https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus_tutorials/package.xml#L24, so it should be installed.
And my original question is "why you need pr2eus from source"?
| @@ -0,0 +1,4 @@ | |||
| - git: | |||
There was a problem hiding this comment.
wnen you create .rosinstall file, please add why you need that package from source, with PR URLs. see -> https://github.com/jsk-ros-pkg/jsk_demos/blob/master/detect_cans_in_fridge_201202/detect_cans_in_fridge_201202.rosinstall
I updated readme. The original one is confusing especially for melodic user. The updated one avoid confusion by checking
$ROS_DISTRO. Also, originally, the workspace created in the example isros/kineticand is confusing for melodic user. Hence, I changed it tocatkin_ws.