Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorial readme melodic #429

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update tutorial readme melodic #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
616af27
Merge remote-tracking branch 'upstream/master'
HiroIshida Mar 31, 2020
fe8f7ab
update readme for melodic user
HiroIshida Apr 1, 2020
401b572
add rosinstall
HiroIshida Apr 5, 2020
cb0e9eb
setup using rosinstall
HiroIshida Apr 5, 2020
4d0245a
remove the option of `Using pre-build package`
HiroIshida Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 9 additions & 34 deletions pr2eus_tutorials/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,58 +4,33 @@ This is a repository for tutorials of pr2eus

## Installation

To play with this package, you can choose from two installation methods.
We assume the ROS environment is `kinetic`.
If you use ROS `indigo` distribution, please replace the word `kinetic` with `indigo` (or appropriate distributions).

### Using pre-built package

#### Install ROS

Follow the [instruction of ROS installation](http://wiki.ros.org/kinetic/Installation/Ubuntu)

#### Install the package

```bash
sudo apt install ros-kinetic-pr2eus-tutorials
```

#### Load ROS Environment

```bash
source /opt/ros/kinetic/setup.bash
```
To play with this package, you can choose from two installation methods. We assume you already installed ROS. If you have not installed yet, for **kinetic user** follow the instuction [here](http://wiki.ros.org/kinetic/Installation/Ubuntu) and for **melodic user** follow the instruction [here](http://wiki.ros.org/melodic/Installation/Ubuntu) to install the ROS.

### Using source package

#### Install ROS

Follow the [instruction of ROS installation](http://wiki.ros.org/kinetic/Installation/Ubuntu)

#### Setup catkin workspace

```bash
source /opt/ros/kinetic/setup.bash
source /opt/ros/$ROS_DISTRO/setup.bash
sudo apt install python-catkin-tools python-wstool python-rosdep git
sudo rosdep init
rosdep update
# Create catkin workspace and download source repository
mkdir -p ~/ros/kinetic/src && cd ~/ros/kinetic/src
wstool init
wstool set jsk-ros-pkg/jsk_pr2eus --git https://github.com/jsk-ros-pkg/jsk_pr2eus.git -v master
wstool update
mkdir -p ~/catkin_ws/src && cd ~/catkin_ws
catkin init
wstool init src
wstool merge -t src https://raw.githubusercontent.com/jsk-ros-pkg/jsk_pr2eus/tree/master/pr2eus_tutorials/pr2eus_tutorials.rosinstall
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HiroIshida Why we install source after sudo apt install ros-$ROS_DISTRO-pr2eus-tutorials at https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/429/files#diff-d9d1ac6a1d0d20412ad36c7e287f0a27R13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original README file, the both section Using pre-build package and Using source package do exit, so I just put both of them with no thought. In the original one, I guess the it was written like that so that a user can select from the two options.

However, I tried the option Using pre-build package, then when run roslaunch pr2eus_tutorials pr2_tabletop_sim.launch physics:=dart of here, I got the following error:

root@0628585147d9:/home$ roslaunch pr2eus_tutorials pr2_tabletop_sim.launch physics:=dart
... logging to /root/.ros/log/1c0079ba-7a99-11ea-b073-0242ac110004/roslaunch-0628585147d9-28828.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

Resource not found: pr2_gazebo
ROS path [0]=/opt/ros/melodic/share/ros
ROS path [1]=/opt/ros/melodic/share
The traceback for the exception was written to the log file

Apparently, pr2_gazebo package is missed in the apt-released version. Also, another command from here does not work because pr2-tabletop-object-grasp.l does not exist in the package.

Thus I now conclude to remove the option of Using pre-build package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure that you ran rosdep install ... command, pr2_gazebo is set run_depends at https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus_tutorials/package.xml#L24, so it should be installed.
And my original question is "why you need pr2eus from source"?

wstool update -t src
# Install dependencies for building the package
rosdep install --from-paths . -i -r -n -y
rosdep install --from-paths src --ignore-src -r -n -y
# Build the package
cd ~/ros/kinetic
catkin init
catkin build
```

#### Load ROS Environment

```bash
source ~/ros/kinetic/devel/setup.bash
source ~/catkin_ws/devel/setup.bash
```

## Tabletop Object Grasping Demo
Expand Down
4 changes: 4 additions & 0 deletions pr2eus_tutorials/pr2eus_tutorials.rosinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- git:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wnen you create .rosinstall file, please add why you need that package from source, with PR URLs. see -> https://github.com/jsk-ros-pkg/jsk_demos/blob/master/detect_cans_in_fridge_201202/detect_cans_in_fridge_201202.rosinstall

local-name: jsk-ros-pkg/jsk_pr2eus
uri: https://github.com/jsk-ros-pkg/jsk_pr2eus.git
version: master