Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window scaling #45 #63

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix window scaling #45 #63

merged 2 commits into from
Jul 9, 2024

Conversation

yxzhan
Copy link
Contributor

@yxzhan yxzhan commented Jul 8, 2024

Solution: Update camera aspect ratio when window resized.

Issue: #45

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Binder 👈 Launch a Binder on branch yxzhan/jupyterlab-urdf/main

@IsabelParedes IsabelParedes added bug Something isn't working enhancement New feature or request labels Jul 9, 2024
IsabelParedes
IsabelParedes approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@IsabelParedes IsabelParedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! This works really well. Thank you @yxzhan 🎉

@IsabelParedes IsabelParedes merged commit 1aac02b into jupyter-robotics:main Jul 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsabelParedes IsabelParedes IsabelParedes approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yxzhan @IsabelParedes