handle IDPs that don't return initials #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
reviewed
Aug 3, 2023
JasonWeill
reviewed
Aug 3, 2023
JasonWeill
reviewed
Aug 3, 2023
JasonWeill
approved these changes
Aug 3, 2023
JasonWeill
approved these changes
Aug 3, 2023
Merged
wolffiex
reviewed
Sep 26, 2023
| chat_user_kwargs = { | ||
| # set in case IdentityProvider doesn't return initials, e.g. | ||
| # JupyterHub (#302) | ||
| "initials": initials, |
There was a problem hiding this comment.
In the case where initials is set to None by the identity provider, this doesn't work. This line should be below the following line.
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* handle IDPs that don't return initials * pre-commit * use current_user.name for default initials * capitalize initials
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* handle IDPs that don't return initials * pre-commit * use current_user.name for default initials * capitalize initials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initials#302This PR should be backported to 1.x.