Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure rate outdated fault event sidebar #652

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Fix failure rate outdated fault event sidebar #652

merged 7 commits into from
Nov 11, 2024

Conversation

kostobog
Copy link
Collaborator

@kostobog kostobog commented Nov 7, 2024

@blcham
Fixes #505

Additionally:

  • refactor status message function/component, remove translation function from its argument
  • show new value in outdated status message for referenced failure rate in external nodes

@kostobog kostobog requested a review from blcham November 8, 2024 11:05
blcham
blcham approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions

public/locales/cs/translation.json Outdated Show resolved Hide resolved
public/locales/cs/translation.json Outdated Show resolved Hide resolved
public/locales/en/translation.json Outdated Show resolved Hide resolved
public/locales/en/translation.json Outdated Show resolved Hide resolved
blcham
blcham reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kostobog see my suggestions in ea9aed4, if they are not ok let me know and i will fix it in separate PR

kostobog and others added 7 commits November 11, 2024 15:58
@blcham blcham force-pushed the fix/505-fix-failure-rate-outdated-fault-event-sidebar branch from bbfa9e1 to ea9aed4 Compare November 11, 2024 14:58
@blcham blcham merged commit 5e7dc0d into main Nov 11, 2024
1 check passed
@blcham blcham deleted the fix/505-fix-failure-rate-outdated-fault-event-sidebar branch November 11, 2024 15:02
@blcham blcham mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure rate is marked as outdated even for newly created FTA node
2 participants
@kostobog @blcham