Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added design doc for sparse checkout #335
added design doc for sparse checkout #335
Changes from 4 commits
733adb9
6352f5b
a52c590
f4e65e2
3927f04
f113f09
d7da73d
8b66da9
cb6d79d
0192fc0
f99daee
2e83c64
4de7d69
19667bd
87c62be
5247cb1
8c768c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I personally think that if there is no
kcl.mod
file in the subdirectory downloaded by the user, we should output diagnostic information and notify the user, rather than generate the file for him, because thekcl.mod
file will affect the compilation result in some cases, if the user does not know that kpm have generated the file for him, it may cause trouble to his use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I recommend that this function should be operated on a valid KCL package and not extended to various files and file directories, so I do not recommend adding support such as
*
or a*.k file
.In the future, if there is a demand for
*
, we can consider the research again to decide whether to support it. It is too early to introduce this feature in the path details.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the workflow for kpm when it get the
kcl.mod
like this, could you please add more details ?The main point that confuse me is:
The main purpose of this work was to support the addition of dependencies from subdirectories of git repo.
It doesn't seem to have anything to do with git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kpm
used to usego-git
to interact with git repo, but one issue that forced me to switch togo-getters
. Let me give you a few more details that may be helpful.When supporting taking git repo as dependencies, there is one tricky issue to consider: authentication.
go-git
and the native git client do not share the same authentication, which means that if you usego-git
, you need to consider the authentication inkpm
and implement it. It's a lot of work.And the authentication part of
go-git
itself is not yet complete: go-git/go-git#490There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. So I will be using go-getter methods.