This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 293
rebase blockifier #1566
Merged
tdelabro
merged 21 commits into
keep-starknet-strange:main
from
tdelabro:rebase-latest-blockifier-single-commit
Apr 25, 2024
Merged
rebase blockifier #1566
tdelabro
merged 21 commits into
keep-starknet-strange:main
from
tdelabro:rebase-latest-blockifier-single-commit
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it compiles madara runs again wip compiles again: only the tests left to fix tests compile, time to fix them remove all default-features option from Cargo.toml new custom execution logic compiles, fewer test fail pallet unitest green all rpc tests ok clippy
tdelabro
force-pushed
the
rebase-latest-blockifier-single-commit
branch
from
April 17, 2024 22:32
1b06b3b
to
ca1a7cf
Compare
cargo machete
crates/primitives/transactions/src/from_broadcasted_transactions.rs
Outdated
Show resolved
Hide resolved
tdelabro
commented
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished reviewing every file. LGTM
EvolveArt
reviewed
Apr 23, 2024
tdelabro
force-pushed
the
rebase-latest-blockifier-single-commit
branch
from
April 23, 2024 22:02
992aecc
to
3e99f89
Compare
EvolveArt
approved these changes
Apr 23, 2024
apoorvsadana
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.