Customizable prefix for cloudevent extensions

[cchayka-campsci]

Proposed Changes

• allow the CloudEvent extension attributes "partition" and "offset" to have a customizable prefix

As brought up before in this issue #3992, a previous version of NodeJS cloudevents would throw an error for any extension > 20 chars in length.

We are in a tough position to update this package for a large number of legacy services, so we were hoping you could consider a change like this for versions 1.14 and onward.

The code I have changed here is incomplete, but I wanted to check if this change would be allowable first.

Basically just adding a new env var "CE_METADATA_EXTENSION_PREFIX" to change the "knativekafka" part of the "knativekafkapartition" and "knativekafkaoffset" CE extensions.

Release Note

:broom: allow customization of the prefix of the CE extensions

Docs

[linux-foundation-easycla]

• ❌ - login: @cchayka-campsci . The commit (188bb08, 0c79658) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cchayka-campsci
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Welcome @cchayka-campsci! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉

[knative-prow]

Hi @cchayka-campsci. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

@cchayka-campsci we're happy to include this one once ready

[cchayka-campsci]

@pierDipi got the unit tests working and ran the formatter

I branched off release-1.14 because that was the version I was hoping to add this back too. Is that okay? Or should I create a new pull request off the main branch and these changes could be cherry-picked after?

[pierDipi]

Or should I create a new pull request off the main branch and these changes could be cherry-picked after?

Yes, that's the best process, we merge changes on main and then merge cherry-picks to release branches

[pierDipi]

Please also take a look at the Linux Foundation CLA #4144 (comment)

[cchayka-campsci]

closing this for a replacement pull request to the main branch #4164