-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configurable CE metadata extension prefix #4164
base: main
Are you sure you want to change the base?
add configurable CE metadata extension prefix #4164
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cchayka-campsci The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The committers listed above are authorized under a signed CLA. |
Hi @cchayka-campsci. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Proposed Changes
As brought up before in this issue #3992, a previous version of NodeJS
cloudevents
would throw an error for any extension > 20 chars in length.We are in a tough position to update this package for a large number of legacy services, so we were hoping you could consider allowing this change.
Basically just adding a new env var "CE_METADATA_EXTENSION_PREFIX" to change the "knativekafka" part of the "knativekafkapartition" and "knativekafkaoffset" CE extensions.
Release Note
Docs
previous pull request to the wrong branch: #4144