Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXBUGS-96): make the secret forms more clear #18

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

JoaoPedroPP
Copy link
Contributor

Migration of KFLUXBUGS-96 to the new repo.

Assure during the migration we move our latest changes.

@JoaoPedroPP JoaoPedroPP marked this pull request as draft November 12, 2024 20:42
@JoaoPedroPP JoaoPedroPP marked this pull request as ready for review November 18, 2024 13:07
@JoaoPedroPP
Copy link
Contributor Author

All local tests passed

image

@caugello
Copy link
Contributor

I would keep the commit msg same as in hac-dev repo, will be easier to understand when reading the history.

@JoaoPedroPP
Copy link
Contributor Author

I would keep the commit msg same as in hac-dev repo, will be easier to understand when reading the history.

Commit message changed to the original

@CryptoRodeo
Copy link
Contributor

/lgtm

@sahil143 sahil143 changed the title chore(KFLUXUI-95): migration of KFLUXBUGS-96 fix(KFLUXBUGS-96): make the secret forms more clear Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.61%. Comparing base (850c442) to head (df1b927).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Secrets/SecretForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files         564      564           
  Lines       20991    20991           
  Branches     5200     5208    +8     
=======================================
  Hits        16712    16712           
- Misses       4254     4255    +1     
+ Partials       25       24    -1     
Flag Coverage Δ
unittests 79.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StanislavJochman
Copy link

/test all

@StanislavJochman
Copy link

/lgtm

@gbenhaim gbenhaim requested a review from sahil143 November 21, 2024 12:47
@gbenhaim
Copy link
Member

/ok-to-test

@JoaoPedroPP
Copy link
Contributor Author

/retest

1 similar comment
@JoaoPedroPP
Copy link
Contributor Author

/retest

@JoaoPedroPP
Copy link
Contributor Author

/retest

@JoaoPedroPP
Copy link
Contributor Author

/retest

@sahil143 sahil143 merged commit c496807 into konflux-ci:main Dec 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants