Support Kotlin/Native #855
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can't wait to run my bot on an apple watch |
|
what's this commit? seems to be related to #836 but that is already on |
|
When I compiled these files were generated |
Need to buy one again for this, or ask @melike2d |
can't believe you think i have enough money for that |
the one in the build dir, sure, but the other ones? |
8 tasks
8 tasks
lukellmann
added a commit
that referenced
this pull request
Sep 3, 2023
The use of value classes for the Reset class has already caused issues implementing #855. However, it was isolated to native platforms. Unfortunately, this behavior will become a compiler error soon, so we need to change it. This can be achieved by simply using the backing Instant instead of Reset with AtomicRef. Related Issues: #855 #69 Kotlin/kotlinx-atomicfu#291 https://youtrack.jetbrains.com/issue/KT-61584 Co-authored-by: lukellmann <[email protected]>
DRSchlaubi
force-pushed
the
feature/native
branch
from
1f7f641
to
0724654
Compare
This was referenced Jan 26, 2024
This was referenced Feb 6, 2024
Closed
|
A workaround for the blocking teamcity bug has been implemented, snapshots are now published to |
- Migrate test-kit to use kotlinx-resources
# Conflicts: # buildSrc/src/main/kotlin/kord-internal-multiplatform-module.gradle.kts # common/build.gradle.kts # gradle/libs.versions.toml
I accidentally reintroduced them in the most recent merge of main into feature/native.
I spent way too much time reading documentation...
# Conflicts: # .github/workflows/gradle-wrapper-validation.yml # buildSrc/src/main/kotlin/kord-internal-multiplatform-module.gradle.kts # buildSrc/src/main/kotlin/kord-module.gradle.kts # buildSrc/src/main/kotlin/kord-multiplatform-module.gradle.kts # core/api/core.api # core/api/core.klib.api # core/live-tests/build.gradle.kts # core/src/commonMain/kotlin/Kord.kt # gateway/api/gateway.api # gateway/api/gateway.klib.api # gateway/src/commonMain/kotlin/Gateway.kt # gateway/src/commonMain/kotlin/Inflater.kt # gateway/src/commonMain/kotlin/Utils.kt # gradle/libs.versions.toml # voice/api/voice.api # voice/src/commonMain/kotlin/gateway/VoiceGateway.kt
lukellmann
reviewed
Jul 5, 2024
| @@ -63,6 +64,8 @@ class KordEventDropTest { | |||
| ) | |||
|
|
|||
| @Test | |||
| // This test seems to timeout sometimes on native | |||
| @IgnoreOnNative | |||
There was a problem hiding this comment.
can we increase/remove the timeout as with js? #926
# Conflicts: # gradle/libs.versions.toml
# Conflicts: # .github/workflows/deployment-ci.yml # .github/workflows/docs-ci.yml # buildSrc/src/main/kotlin/kord-internal-multiplatform-module.gradle.kts # buildSrc/src/main/kotlin/kord-module.gradle.kts # buildSrc/src/main/kotlin/kord-multiplatform-module.gradle.kts # buildSrc/src/main/kotlin/kord-publishing.gradle.kts # core/src/commonMain/kotlin/Kord.kt # gateway/src/commonMain/kotlin/Gateway.kt # gateway/src/commonMain/kotlin/Utils.kt # gradle/libs.versions.toml # ksp-annotations/build.gradle.kts # voice/src/commonMain/kotlin/gateway/VoiceGateway.kt
lukellmann
reviewed
Sep 18, 2024
Comment on lines
8
to
12
| internal actual fun formatIntegerFromLittleEndianLongArray(data: LongArray): String { | ||
| val buffer = Buffer() | ||
| data.reversedArray().forEach(buffer::writeLong) | ||
| return BigInteger.fromByteArray(buffer.readByteArray(), Sign.POSITIVE).toString() | ||
| } |
There was a problem hiding this comment.
just in case, an alternative implementation:
internal actual fun formatIntegerFromLittleEndianLongArray(data: LongArray): String {
// need to convert from little-endian data to big-endian expected by BigInteger
val bytes = ByteArray(size = data.size * Long.SIZE_BYTES)
val lastIndex = data.lastIndex
for (i in 0..lastIndex) {
val long = data[i]
val offset = (lastIndex - i) * Long.SIZE_BYTES
bytes[offset + 0] = long.ushr(56).toByte()
bytes[offset + 1] = long.ushr(48).toByte()
bytes[offset + 2] = long.ushr(40).toByte()
bytes[offset + 3] = long.ushr(32).toByte()
bytes[offset + 4] = long.ushr(24).toByte()
bytes[offset + 5] = long.ushr(16).toByte()
bytes[offset + 6] = long.ushr(8).toByte()
bytes[offset + 7] = long.ushr(0).toByte()
}
return BigInteger.fromByteArray(bytes, Sign.POSITIVE).toString()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at implementing Kotlin/Native for the following platforms:
Experimental Snapshot
There currently is an experimental snapshot on OSSRH under the
feature-native-SNAPSHOTfor you to tryAn example implementation can be found here
Please note that you need to configure our custom repository:
Gradle Configuration
repositories { // Required for custom Ktor build maven("https://europe-west3-maven.pkg.dev/mik-music/kord") maven("https://oss.sonatype.org/content/repositories/snapshots/") mavenCentral() } kotlin { sourceSets { commonMain { dependencies { implementation("dev.kord:kord-core:feature-native-SNAPSHOT") } } } }Current limitations
Checklist
Blocked by
TW-86481(Workaround implemented)