Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RealSandook impl for Sandook KeyValueStore #215

Merged

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 19, 2024

TL;DR

Implemented Sandook, a key-value storage interface, using SharedPreferences.

What changed?

  • Added Sandook interface with methods for storing and retrieving various data types.
  • Implemented RealSandook class using SharedPreferences to provide concrete implementation.
  • Created SandookModule for dependency injection.
  • Updated build configurations to support the new implementation.

Why make this change?

This change introduces a standardized key-value storage solution for the app. By abstracting the storage mechanism behind an interface, we gain flexibility to change the underlying implementation in the future if needed. Using SharedPreferences provides a simple and efficient way to store small amounts of primitive data, which is suitable for most app settings and preferences.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

This was referenced Oct 19, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 19, 2024 13:03
@ksharma-xyz ksharma-xyz force-pushed the 10-19-add_realsandook_impl_for_sandook_keyvaluestore branch from 7b2785c to 2b3c038 Compare October 19, 2024 13:05
@ksharma-xyz ksharma-xyz merged commit a91a69d into main Oct 19, 2024
1 check passed
Copy link
Owner Author

Merge activity

  • Oct 19, 9:12 AM EDT: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 10-19-add_realsandook_impl_for_sandook_keyvaluestore branch October 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant