Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Save Trip functionality #216

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 19, 2024

TL;DR

Added functionality to save trips and display saved trip status in the TimeTableScreen.

What changed?

  • Added isTripSaved boolean to TimeTableState
  • Implemented serialization and deserialization methods for Trip class
  • Added a "Save Trip" button to the TimeTableScreen
  • Implemented trip saving functionality in TimeTableViewModel using Sandook
  • Updated TimeTableScreen to display "Trip Saved" when a trip is saved

Why make this change?

This change allows users to save their trips for future reference, enhancing the app's functionality and user experience. It provides a convenient way for users to keep track of their frequently used or important trips without having to re-enter the information each time.

Copy link
Owner Author

ksharma-xyz commented Oct 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 19, 2024 13:03
@ksharma-xyz ksharma-xyz force-pushed the 10-19-add_realsandook_impl_for_sandook_keyvaluestore branch from 7b2785c to 2b3c038 Compare October 19, 2024 13:05
@ksharma-xyz ksharma-xyz force-pushed the 10-19-implement_save_trip_functionality branch from 317920b to 59a10a5 Compare October 19, 2024 13:05
Base automatically changed from 10-19-add_realsandook_impl_for_sandook_keyvaluestore to main October 19, 2024 13:12
@ksharma-xyz ksharma-xyz force-pushed the 10-19-implement_save_trip_functionality branch from 59a10a5 to b97c2db Compare October 19, 2024 13:18
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) October 19, 2024 13:18
@ksharma-xyz ksharma-xyz force-pushed the 10-19-implement_save_trip_functionality branch from b97c2db to f9cebe2 Compare October 19, 2024 13:26
Copy link
Owner Author

ksharma-xyz commented Oct 19, 2024

Merge activity

  • Oct 19, 9:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 19, 9:30 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 19, 9:35 AM EDT: Graphite rebased this pull request as part of a merge.

@ksharma-xyz ksharma-xyz force-pushed the 10-19-implement_save_trip_functionality branch 3 times, most recently from b243fb9 to b8549e3 Compare October 19, 2024 13:35
@ksharma-xyz ksharma-xyz force-pushed the 10-19-implement_save_trip_functionality branch from b8549e3 to ad06ae0 Compare October 19, 2024 13:35
@ksharma-xyz ksharma-xyz merged commit 90976df into main Oct 19, 2024
1 check passed
@ksharma-xyz ksharma-xyz deleted the 10-19-implement_save_trip_functionality branch October 19, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant