Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Refine JourneyCard styling and interaction #251

Merged
merged 1 commit into from
Oct 26, 2024
Merged

UI: Refine JourneyCard styling and interaction #251

merged 1 commit into from
Oct 26, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 23, 2024 •
edited
Loading

TL;DR

Updated JourneyCard component and TimeTableScreen to improve UI interactions and visual consistency.

What changed?

  • Modified JourneyCard to conditionally apply border and padding based on card state
  • Added MutableInteractionSource and removed indication from clickable modifier
  • Updated TimeTableScreen to use COLLAPSED state instead of EXPANDED for expanded journey cards

Why make this change?

These changes enhance the user experience by:

  1. Improving visual consistency across different card states
  2. Providing better touch feedback for card interactions
  3. Streamlining the expanded state representation in the TimeTableScreen

This was referenced Oct 23, 2024
Merged
Merged
Merged
Merged
Merged
@ksharma-xyz Graphite App
Copy link
Owner Author

ksharma-xyz commented Oct 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

This was referenced Oct 23, 2024
Merged
Merged
@ksharma-xyz ksharma-xyz force-pushed the 10-23-delete_old_ui_for_journeydetailcard branch from a7bc839 to 4fb944c Compare October 24, 2024 12:16
@ksharma-xyz ksharma-xyz force-pushed the 10-23-no_border_when_looking_at_detail_as_we_need_more_space branch from 7e2e0cd to fe6e47b Compare October 24, 2024 12:16
@ksharma-xyz ksharma-xyz mentioned this pull request Oct 24, 2024
Merged
@ksharma-xyz ksharma-xyz force-pushed the 10-23-delete_old_ui_for_journeydetailcard branch from 4fb944c to 14c402f Compare October 24, 2024 15:02
@ksharma-xyz ksharma-xyz force-pushed the 10-23-no_border_when_looking_at_detail_as_we_need_more_space branch from fe6e47b to c822492 Compare October 24, 2024 15:03
@ksharma-xyz ksharma-xyz force-pushed the 10-23-delete_old_ui_for_journeydetailcard branch from 14c402f to 068fbce Compare October 26, 2024 03:42
@ksharma-xyz ksharma-xyz force-pushed the 10-23-no_border_when_looking_at_detail_as_we_need_more_space branch from c822492 to 2f83db1 Compare October 26, 2024 03:43
@ksharma-xyz ksharma-xyz force-pushed the 10-23-delete_old_ui_for_journeydetailcard branch from 068fbce to 46c7105 Compare October 26, 2024 03:48
Base automatically changed from 10-23-delete_old_ui_for_journeydetailcard to main October 26, 2024 03:54
@ksharma-xyz ksharma-xyz force-pushed the 10-23-no_border_when_looking_at_detail_as_we_need_more_space branch from 2f83db1 to 9a0d85a Compare October 26, 2024 03:56
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 26, 2024 03:56
@ksharma-xyz ksharma-xyz changed the title No border when looking at detail as we need more space UI: Refine JourneyCard styling and interaction Oct 26, 2024
@ksharma-xyz ksharma-xyz force-pushed the 10-23-no_border_when_looking_at_detail_as_we_need_more_space branch from 9a0d85a to 636ef66 Compare October 26, 2024 03:58
@ksharma-xyz ksharma-xyz merged commit f91e771 into main Oct 26, 2024
1 check passed
@ksharma-xyz ksharma-xyz deleted the 10-23-no_border_when_looking_at_detail_as_we_need_more_space branch October 26, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ksharma-xyz