Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Refactor JourneyCard clickable area and simplify stops display #254

Merged
merged 1 commit into from
Oct 26, 2024
Merged

UI: Refactor JourneyCard clickable area and simplify stops display #254

merged 1 commit into from
Oct 26, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 24, 2024 •
edited
Loading

TL;DR

Improved JourneyCard and LegView components for better user interaction and display.

What changed?

  • Moved clickable modifier from JourneyCard to its content components for more precise touch areas.
  • Removed redundant platform number display and info icon from JourneyCardContent.
  • Simplified LegView by moving clickable modifier to the main column and adjusting the stops display logic.
  • Updated plurals string resource for stops to be more concise.

Why make this change?

These changes improve the user experience by:

  1. Providing more precise touch areas in JourneyCards.
  2. Simplifying the UI by removing redundant information.
  3. Making the LegView component more intuitive to interact with.
  4. Enhancing the readability of the stops count display.

This was referenced Oct 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ksharma-xyz Graphite App
Copy link
Owner Author

ksharma-xyz commented Oct 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz mentioned this pull request Oct 24, 2024
Merged
@ksharma-xyz ksharma-xyz force-pushed the 10-24-show_hide_stops_by_clicking_on_it branch from d2c8b79 to 5b3e4de Compare October 24, 2024 15:03
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from ad58d01 to 2ec6900 Compare October 24, 2024 15:03
@ksharma-xyz ksharma-xyz force-pushed the 10-24-show_hide_stops_by_clicking_on_it branch from 5b3e4de to 03e11cb Compare October 26, 2024 03:56
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from 2ec6900 to 829565a Compare October 26, 2024 03:56
@ksharma-xyz ksharma-xyz changed the title [TEMP] - UX braintorming with Adi UI: Refactor JourneyCard clickable area and simplify stops display Oct 26, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 26, 2024 03:57
@ksharma-xyz ksharma-xyz force-pushed the 10-24-show_hide_stops_by_clicking_on_it branch from 03e11cb to 41eb88d Compare October 26, 2024 03:58
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from 829565a to c893c6d Compare October 26, 2024 03:58
@ksharma-xyz ksharma-xyz force-pushed the 10-24-show_hide_stops_by_clicking_on_it branch from 41eb88d to 311326c Compare October 26, 2024 04:13
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from c893c6d to cb3f036 Compare October 26, 2024 04:13
@ksharma-xyz ksharma-xyz force-pushed the 10-24-show_hide_stops_by_clicking_on_it branch from 311326c to 96e2838 Compare October 26, 2024 04:14
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from cb3f036 to bfb2932 Compare October 26, 2024 04:14
@ksharma-xyz ksharma-xyz force-pushed the 10-24-show_hide_stops_by_clicking_on_it branch from 96e2838 to 5db4ab9 Compare October 26, 2024 04:27
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from bfb2932 to 63ef42b Compare October 26, 2024 04:28
@ksharma-xyz ksharma-xyz changed the base branch from 10-24-show_hide_stops_by_clicking_on_it to graphite-base/254 October 26, 2024 04:34
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from 63ef42b to f2f5a76 Compare October 26, 2024 04:34
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/254 to main October 26, 2024 04:34
@ksharma-xyz ksharma-xyz force-pushed the 10-24-_temp_-_ux_braintorming_with_adi branch from f2f5a76 to 3235dd5 Compare October 26, 2024 04:34
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) October 26, 2024 04:38
@ksharma-xyz ksharma-xyz merged commit e1b2c9b into main Oct 26, 2024
1 check passed
@ksharma-xyz ksharma-xyz deleted the 10-24-_temp_-_ux_braintorming_with_adi branch October 26, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ksharma-xyz