Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeflow: remove operator test in pr check #16

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Feb 20, 2024

Description

Remove the operator check during the PR build check as not needed in kubeflow

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@198fb0e). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage        ?   76.19%           
=======================================
  Files           ?       17           
  Lines           ?     2033           
  Branches        ?       74           
=======================================
  Hits            ?     1549           
  Misses          ?      299           
  Partials        ?      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can eventually replace these with some testing of the manifests, but for the moment /lgtm thank you @lampajr

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lampajr, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 20, 2024
@google-oss-prow google-oss-prow bot merged commit 7bcdc49 into kubeflow:main Feb 20, 2024
11 checks passed
@tarilabs
Copy link
Member

/approve
/lgtm

@lampajr lampajr deleted the remove_operator_check branch February 20, 2024 11:54
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs pushed a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
@tarilabs tarilabs mentioned this pull request Mar 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants