-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeflow: remove operator test in pr check #16
Conversation
Signed-off-by: Andrea Lamparelli <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage ? 76.19%
=======================================
Files ? 17
Lines ? 2033
Branches ? 74
=======================================
Hits ? 1549
Misses ? 299
Partials ? 185 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can eventually replace these with some testing of the manifests, but for the moment /lgtm thank you @lampajr
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lampajr, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/approve |
This reverts commit 7bcdc49.
Signed-off-by: Andrea Lamparelli <[email protected]>
This reverts commit 7bcdc49.
This reverts commit 7bcdc49.
This reverts commit 7bcdc49.
Description
Remove the operator check during the PR build check as not needed in kubeflow
How Has This Been Tested?
Merge criteria: