add testing of KF MR Manifests #36
Conversation
tarilabs
force-pushed
the
tarilabs-20240311-35
branch
2 times, most recently
from
f76dbd6 to
d7fad71
Compare
Signed-off-by: Matteo Mortari <[email protected]>
tarilabs
force-pushed
the
tarilabs-20240311-35
branch
from
d7fad71 to
fbd758c
Compare
| uses: helm/[email protected] | ||
| - name: Load Local Registry Test Image | ||
| env: | ||
| IMG: "quay.io/opendatahub/model-registry:${{ steps.tags.outputs.tag }}" |
There was a problem hiding this comment.
Either in this PR or in a separate one, we'll need to replace references to quay with dockerhub instead. I think this action doesn't push/pull images from quay, but it could be confusing to a new reader.
There was a problem hiding this comment.
Or better yet, replace with generic variables like DOCKER_REPO.
There was a problem hiding this comment.
This PR focus on Kind testing.
Indeed that can/will be done in separate PR
There was a problem hiding this comment.
I think this action doesn't push/pull images from quay
can confirm, here:
once Kind is in-place as it was pre-migration, we can use parametric image name also here, and would be a great non-regression testing that image creation and publishing (to dockerhub).
|
@dhirajsb: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhirajsb, rareddy, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit aeeffc0.
* Added DSCI config * This commit corrects the order in which the DSCI is applied uses the correct default dsci needed for correct application * This commit adds a script to test if yq is installed and installs it if it isn't * This commit removes the script call as it is not needed
resolves #35
Description
Use Kind GHA script to dry-run the Model Registry image built on a pull_request, use similarly to previously existing strategy, now adapted from using Operator pattern to use Manifest and Kind.
How Has This Been Tested?
demo here
Merge criteria: