Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing of KF MR Manifests #36

Merged
merged 1 commit into from
Mar 14, 2024
Merged

add testing of KF MR Manifests #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/build-image-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,24 @@ jobs:
env:
VERSION: ${{ steps.tags.outputs.tag }}
run: ./scripts/build_deploy.sh
- name: Start Kind Cluster
uses: helm/[email protected]
- name: Load Local Registry Test Image
env:
IMG: "quay.io/opendatahub/model-registry:${{ steps.tags.outputs.tag }}"
Copy link
Contributor

@dhirajsb dhirajsb Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either in this PR or in a separate one, we'll need to replace references to quay with dockerhub instead. I think this action doesn't push/pull images from quay, but it could be confusing to a new reader.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better yet, replace with generic variables like DOCKER_REPO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR focus on Kind testing.

Indeed that can/will be done in separate PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this action doesn't push/pull images from quay

can confirm, here:

model-registry/.github/workflows/build-image-pr.yml

Line 15 in 962c78d

PUSH_IMAGE: false

once Kind is in-place as it was pre-migration, we can use parametric image name also here, and would be a great non-regression testing that image creation and publishing (to dockerhub).

run: |
kind load docker-image -n chart-testing ${IMG}
- name: Create Test Registry
env:
IMG: "quay.io/opendatahub/model-registry:${{ steps.tags.outputs.tag }}"
run: |
echo "Deploying Model Registry using Manifests; branch ${BRANCH}"
kubectl create namespace kubeflow
cd manifests/kustomize/overlays/db
kustomize edit set image quay.io/opendatahub/model-registry:latest $IMG
kubectl apply -k .
- name: Wait for Test Registry Deployment
run: |
kubectl wait --for=condition=available -n kubeflow deployment/model-registry-db --timeout=5m
kubectl wait --for=condition=available -n kubeflow deployment/model-registry-deployment --timeout=5m
kubectl logs -n kubeflow deployment/model-registry-deployment
Loading