Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAS: fix minor issues and bump version #29

Merged
merged 3 commits into from
Mar 13, 2024
Merged

OAS: fix minor issues and bump version #29

merged 3 commits into from
Mar 13, 2024

Conversation

isinyaaa
Copy link
Contributor

@isinyaaa isinyaaa commented Mar 5, 2024 •
edited
Loading

Start by replacing ID -> Id to preserve camelCase. Then fix
PATCH /model_versions/{mv_id} to take in a ModelVersionUpdate.

Description

Some code generators, especially in languages that use snake case, will turn those parameter names to e.g. external_i_d, which is unexpected. We also get type issues when using a ModelVersionUpdate, as there's no route that takes it.

How Has This Been Tested?

Following the same steps laid out on the last PR referencing OAS #17:

make FORCE_SERVER_GENERATION=true clean build
make test

then,

  1. start an MLMD server
  2. run make proxy
  3. run robot test/robot/ && TEST_MODE=python robot test/robot/MRandLogicalModel.robot

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@isinyaaa isinyaaa marked this pull request as ready for review March 5, 2024 19:52
@google-oss-prow google-oss-prow bot requested review from rareddy and zijianjoy March 5, 2024 19:52
@isinyaaa isinyaaa marked this pull request as draft March 7, 2024 15:35
isinyaaa and others added 2 commits March 8, 2024 10:28
@isinyaaa
OAS: fixup ID -> Id in parameter names
a8fb190 
... to preserve camelCase.

Signed-off-by: Isabella Basso do Amaral <[email protected]>
@tarilabs @isinyaaa
fix REST api to use ModelVersionUpdate in PATCH method
9a51c58 
Signed-off-by: Matteo Mortari <[email protected]>
@isinyaaa isinyaaa marked this pull request as ready for review March 8, 2024 13:35
@google-oss-prow google-oss-prow bot requested a review from Tomcli March 8, 2024 13:36
@isinyaaa isinyaaa changed the title OAS: fixup ID -> Id in parameter names OAS: fix minor issues and bump version Mar 8, 2024
@isinyaaa
bump OAS version to v1alpha3
bb1101d 
Signed-off-by: Isabella Basso do Amaral <[email protected]>
@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024 •
edited
Loading

@isinyaaa based on: https://github.com/kubeflow/model-registry/actions/runs/8204093394/job/22438052976?pr=29#step:9:1

would look like go codegen was not fully committed; I remember sometimes this was a different behaviour of codegen on my Mac machine "Vs" @lampajr Fedora machine, so in case could be the changed I introduced with 9a51c58 are not ordered correctly if compared to main.

edit: thank you for making me notice, in this case highlights the protobuf version used on the machine was different ✍️

tarilabs
tarilabs approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start by replacing ID -> Id to preserve camelCase. Then fix
PATCH /model_versions/{mv_id} to take in a ModelVersionUpdate.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 13, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isinyaaa, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 962c78d into kubeflow:main Mar 13, 2024
11 checks passed
@isinyaaa isinyaaa deleted the id-fixup branch March 13, 2024 12:04
@tarilabs tarilabs mentioned this pull request Mar 18, 2024
Merged
tarilabs pushed a commit to tarilabs/model-registry that referenced this pull request Mar 26, 2024
@tonyxrmdavidson
This commit will update the iib for odh-nightly build (kubeflow#29)
18d77fa 
* This commit will update the iib for odh-nightly build
and fix the paths as the script will be run from the root of the repo instead of directly from the host directory

* This commit removes color text from echo statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ckadner ckadner Awaiting requested review from ckadner

@rareddy rareddy Awaiting requested review from rareddy

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@Tomcli Tomcli Awaiting requested review from Tomcli

Assignees

@tarilabs tarilabs

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isinyaaa @tarilabs