Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS: fix minor issues and bump version #29

Merged
merged 3 commits into from
Mar 13, 2024
Merged

OAS: fix minor issues and bump version #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8fb190
OAS: fixup ID -> Id in parameter names
isinyaaa Mar 5, 2024
9a51c58
fix REST api to use ModelVersionUpdate in PATCH method
tarilabs Mar 8, 2024
bb1101d
bump OAS version to v1alpha3
isinyaaa Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 46 additions & 46 deletions api/openapi/model-registry.yaml
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions csi/GET_STARTED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Then, in the same terminal where you exported `MR_HOSTNAME`, perform the followi

```bash
curl --silent -X 'POST' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models" \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{
Expand All @@ -100,7 +100,7 @@ Expected output:

```bash
curl --silent -X 'POST' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions" \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{
Expand All @@ -121,7 +121,7 @@ This artifact defines where the actual trained model is stored, i.e., `gs://kfse

```bash
curl --silent -X 'POST' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/2/artifacts" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/2/artifacts" \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{
Expand Down Expand Up @@ -246,4 +246,4 @@ If you do not have DNS, you can still curl with the ingress gateway external IP
```bash
SERVICE_HOSTNAME=$(kubectl get inferenceservice iris-model -n kserve-test -o jsonpath='{.status.url}' | cut -d "/" -f 3)
curl -v -H "Host: ${SERVICE_HOSTNAME}" -H "Content-Type: application/json" "http://${INGRESS_HOST}:${INGRESS_PORT}/v1/models/iris-v1:predict" -d @/tmp/iris-input.json
```
```
24 changes: 12 additions & 12 deletions docs/logical_model.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ resulting in:

```
curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/1" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/1" \
-H 'accept: application/json' | jq
{
"createTimeSinceEpoch": "1707765353963",
Expand All @@ -99,7 +99,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/1/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/1/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
-H 'accept: application/json' | jq
{
"items": [
Expand All @@ -120,7 +120,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/2/artifacts" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/2/artifacts" \
-H 'accept: application/json' | jq
{
"items": [
Expand Down Expand Up @@ -167,7 +167,7 @@ resulting in:

```
curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/3" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/3" \
-H 'accept: application/json' | jq
{
"createTimeSinceEpoch": "1707765756856",
Expand All @@ -179,7 +179,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/3/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/3/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
-H 'accept: application/json' | jq
{
"items": [
Expand All @@ -200,7 +200,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/4/artifacts" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/4/artifacts" \
-H 'accept: application/json' | jq
{
"items": [
Expand Down Expand Up @@ -247,7 +247,7 @@ resulting in:

```
curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/5" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/5" \
-H 'accept: application/json' | jq
{
"createTimeSinceEpoch": "1707765990857",
Expand All @@ -259,7 +259,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/5/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/5/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
-H 'accept: application/json' | jq
{
"items": [
Expand Down Expand Up @@ -290,7 +290,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/6/artifacts" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/6/artifacts" \
-H 'accept: application/json' | jq
{
"items": [
Expand Down Expand Up @@ -362,7 +362,7 @@ resulting in:

```
curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/7" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/7" \
-H 'accept: application/json' | jq
{
"createTimeSinceEpoch": "1707766117250",
Expand All @@ -374,7 +374,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models/7/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models/7/versions?pageSize=100&orderBy=ID&sortOrder=DESC&nextPageToken=" \
-H 'accept: application/json' | jq
{
"items": [
Expand All @@ -395,7 +395,7 @@ curl --silent -X 'GET' \
}

curl --silent -X 'GET' \
"$MR_HOSTNAME/api/model_registry/v1alpha2/model_versions/8/artifacts" \
"$MR_HOSTNAME/api/model_registry/v1alpha3/model_versions/8/artifacts" \
-H 'accept: application/json' | jq
{
"items": [
Expand Down
14 changes: 7 additions & 7 deletions internal/converter/generated/mlmd_openapi_converter.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 36 additions & 36 deletions internal/converter/generated/openapi_converter.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading