Issue3492 direct evaporative cooler #3755
Conversation
Merge lbl master into pnnl master
Merge latest master
Issue3492 direct evaporative cooler
…porative cooler calculations
…veCooler Issue3492 direct evaporative cooler
| parameter Modelica.Units.SI.Length dep | ||
| "Depth of the rigid media evaporative pad"; | ||
|
|
||
| parameter Real effCoe[11] = {0.792714, 0.958569, -0.25193, -1.03215, 0.0262659, |
There was a problem hiding this comment.
Can the user change the effCoe[:]? Is it from the E+ reference? If it shall not be changed, make it to be protected.
|
|
||
| Buildings.Controls.OBC.CDL.Interfaces.RealInput V_flow( | ||
| final unit="m3/s", | ||
| displayUnit="m3/s", |
There was a problem hiding this comment.
no need to have the displayUnit as it is same as unit.
|
|
||
| Buildings.Controls.OBC.CDL.Interfaces.RealOutput dmWat_flow( | ||
| final unit="kg/s", | ||
| displayUnit="kg/s", |
There was a problem hiding this comment.
remove displayUnit
…ativeCooler Issue3492 direct evaporative cooler
…m/lbl-srg/modelica-buildings into issue3492_DirectEvaporativeCooler
|
@karthikeyad-pnnl See below comments:
|
…g/modelica-buildings into lbl-srg-issue3492_DirectEvaporativeCooler
…92_DirectEvaporativeCooler
…ativeCooler Issue3492 direct evaporative cooler
|
@karthikeyad-pnnl The reference results have been updated. I wonder if it is still a draft PR? Are you working on any other issues for this PR? |
|
@karthikeyad-pnnl Can this PR become formal PR? |
This closes #3492.