Upgrade to vue2.7 and remove @vue/composition-api. #12933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #9538
Reviewer guidance
Run the devserver, make sure to interact with both composable and options API based code.
I am fairly sure the last time we upgraded @vueuse/core we reverted it because it wasn't compatible with Vue 2.6, but it is compatible with Vue 2.7 - if you can find any evidence or discussion about this to confirm, that would be great.
Make sure that all globally registered things (like vue-intl methods, core theme etc) are working fine.
Question - why do we have two nearly (but not quite) identical copies of the search composable tests, one in learn, one in kolibri-common?