Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to vue2.7 and remove @vue/composition-api. #12933

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Upgrades KDS to the latest rc that uses Vue 2.7
  • Upgrades Vue to latest 2.7 and the associated template compiler
  • Removes @vue/composition-api plugin completely
  • Upgrades @vueuse/core to the latest version compatible with Vue 2
  • Updates all named imports from @vue/composition-api to vue
  • Removes registration of the @vue/composition-api plugin
  • Updates our webpack configuration as apparently the janky dev/prod module exposure that was used in @vue/composition-api is now being used in vue2.7
  • Regenerates the core API to account for the removal of the @vue/composition-api plugin
  • Updates the moduleMapping for core API migration to convert all references to vue instead

References

Fixes #9538

Reviewer guidance

Run the devserver, make sure to interact with both composable and options API based code.
I am fairly sure the last time we upgraded @vueuse/core we reverted it because it wasn't compatible with Vue 2.6, but it is compatible with Vue 2.7 - if you can find any evidence or discussion about this to confirm, that would be great.
Make sure that all globally registered things (like vue-intl methods, core theme etc) are working fine.

Question - why do we have two nearly (but not quite) identical copies of the search composable tests, one in learn, one in kolibri-common?

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend DEV: tools Internal tooling for development labels Dec 11, 2024
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- changes make sense

@AlexVelezLl
Copy link
Member

Thank you @rtibbles!

@AlexVelezLl AlexVelezLl merged commit f408a44 into learningequality:develop Dec 12, 2024
36 checks passed
@rtibbles rtibbles deleted the vue2.7 branch December 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: frontend DEV: tools Internal tooling for development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Vue 2.7
3 participants