Fix error with samples implementation #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there @dankcushions , sorry for noticing this so late. Does the PR linked to by grant2258 already cover this or not? |
|
yes i believe so |
ghost
mentioned this pull request
Merged
|
@twinaphex I don't think you wanted to close this - it still needs merging, no? see comments in #96 - they removed the duplicated fix and resubmitted the PR. this PR is still needed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies, I made a bug with the previous PR.
DO NOT MERGE. Let me give this a thorough test first.I was getting a crash with asteroid.zip, but that appears unrelated: #87