Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FundPsbt and EstimateFee improvements #4845

Closed
wants to merge 1 commit into from
Closed

FundPsbt and EstimateFee improvements #4845

wants to merge 1 commit into from

Commits on Dec 8, 2020

  1. FundPsbt and EstimateFee improvements 

    `FundPsbt` and `EstimateFee` now support spending from the underlying
wallet using unconfirmed inputs or inputs with a specific number of
minumum confirmations; this is made possible by adding the
params `min_confs` and `spend_unconfirmed` to the underlying proto
messages, and implementing checks in their function calls.

This commit also changes the interface of `WalletController` slightly; it
adds the param `minConfs` to `CreateSimpleTx` inside the
`WalletController` interface, thus allowing the underlying
implementation of the function to pass `minConfs` to its
underlying wallet's `createsimpletx` implementation (if possible and/or desired).
    @jalavosus
    jalavosus committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    e7984c0 View commit details
    Browse the repository at this point in the history