FundPsbt and EstimateFee improvements #4845
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FundPsbt
andEstimateFee
now support spending from the underlyingwallet using unconfirmed inputs or inputs with a specific number of
minumum confirmations; this is made possible by adding the
params
min_confs
andspend_unconfirmed
to the underlying protomessages, and implementing checks in their function calls.
This commit also changes the interface of
WalletController
slightly; itadds the param
minConfs
toCreateSimpleTx
inside theWalletController
interface, thus allowing the underlyingimplementation of the function to pass
minConfs
to itsunderlying wallet's
createsimpletx
implementation (if possible and/or desired).Pull Request Checklist
Contribution Guidelines
the positive and negative (error paths) conditions (if applicable)
the bug being fixed to prevent regressions
logging level
go fmt
lnrpc/**/*.proto
) have been formatted withmake rpc-format
and compiled withmake rpc
sample-lnd.conf
(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
make check
does not fail any testsgo vet
does not report any issuesmake lint
does not report any new issues that did notalready exist
cases it can be justifiable to violate this condition. In that case, the
reason should be stated in the commit message.