Support spend_unconfirmed in EstimateFee and FundPsbt #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
force-pushed
the
feat/spend-unconfirmed-estimate
branch
3 times, most recently
from
fd8ffb5 to
28f7d72
Compare
15 tasks
Roasbeef
added
enhancement
mrfelton
force-pushed
the
feat/spend-unconfirmed-estimate
branch
2 times, most recently
from
c90afb7 to
84caf9d
Compare
mrfelton
force-pushed
the
feat/spend-unconfirmed-estimate
branch
from
84caf9d to
00bbb15
Compare
guggero
reviewed
Feb 9, 2021
|
I'd love to see this change, it would help me doing CPFPs a lot |
|
Ping @mrfelton. If you're still available to work on this, we can try to get it merged for v0.13. |
|
Sure, I'll take a look. Missed the last batch of updates on this one somehow. Have been running with this patch for some months though. |
mrfelton
force-pushed
the
feat/spend-unconfirmed-estimate
branch
from
00bbb15 to
f57c98b
Compare
mrfelton
force-pushed
the
feat/spend-unconfirmed-estimate
branch
from
f57c98b to
2f80283
Compare
guggero
approved these changes
Apr 23, 2021
wpaulino
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #4845. I'm not sure what happened to that original PR but it seems the repo where it came from is no longer online.
FundPsbtandEstimateFeenow support spending from the underlying wallet using unconfirmed inputs or inputs with a specific number of minumum confirmations; this is made possible by adding the paramsmin_confsandspend_unconfirmedto the underlying proto messages, and implementing checks in their function calls.It changes the interface of
WalletControllerslightly; it adds the paramminConfstoCreateSimpleTxinside theWalletControllerinterface, thus allowing the underlying implementation of the function to passminConfsto its underlying wallet'screatesimpletximplementation (if possible and/or desired).