Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches on the asv workflows #317

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Patches on the asv workflows #317

merged 2 commits into from
Nov 9, 2023

Conversation

camposandro
Copy link
Contributor

@camposandro camposandro commented Nov 8, 2023

Applies two small fixes on the asv-main and asv-nightly workflows:

  • The asv-nightly workflow is failing because we're trying to compare two commit hashes and their benchmark results are not present in the action's working directory. Previously this was not a requirement but for asv v0.0.6+ we're seeing exceptions about it (example).

  • According to the asv 0.6.1 changelog both asv run and asv continuous return a non-zero exit code if any of the benchmarks fail. In the case of asv-main, we still want to allow the workflow to finish so that the results are stored and the dashboard is updated (hence || true).

It closes #62, issue created for hipscat but that will in fact affect all projects based on the template.

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@camposandro camposandro self-assigned this Nov 8, 2023
@camposandro camposandro marked this pull request as ready for review November 8, 2023 21:56
@camposandro camposandro merged commit df5de37 into main Nov 9, 2023
15 checks passed
@camposandro camposandro deleted the fix-asv-nightly-workflow branch November 9, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASV nightly job failing
2 participants