Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies two small fixes on the asv-main and asv-nightly workflows:
The asv-nightly workflow is failing because we're trying to compare two commit hashes and their benchmark results are not present in the action's working directory. Previously this was not a requirement but for asv v0.0.6+ we're seeing exceptions about it (example).
According to the asv 0.6.1 changelog both
asv run
andasv continuous
return a non-zero exit code if any of the benchmarks fail. In the case of asv-main, we still want to allow the workflow to finish so that the results are stored and the dashboard is updated (hence|| true
).It closes #62, issue created for hipscat but that will in fact affect all projects based on the template.
Checklist
lincc-frameworks/python-project-template
repo and not a downstream one instead.